Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: MLnick <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12200-spark@git.apache.org>
In-Reply-To: <git-pr-12200-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-14392][ML]CountVectorizer
 Estimator sho...
Content-Type: text/plain
Message-Id: <20160407070147.3A89AE050B@git1-us-west.apache.org>
Date: Thu,  7 Apr 2016 07:01:47 +0000 (UTC)

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12200#discussion_r58826834
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
    @@ -127,6 +146,9 @@ class CountVectorizer(override val uid: String)
       /** @group setParam */
       def setMinTF(value: Double): this.type = set(minTF, value)
     
    +  /** @group setParam */
    +  def setBinary(value: Boolean): this.type = set(binary, value)
    +
       setDefault(vocabSize -> (1 << 18), minDF -> 1)
    --- End diff --
    
    @wangmiao1981 please move the `setDefault` call here as per @BryanCutler's comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org