Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9DF3019CC2 for ; Mon, 4 Apr 2016 18:08:09 +0000 (UTC) Received: (qmail 72289 invoked by uid 500); 4 Apr 2016 18:08:09 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 72266 invoked by uid 500); 4 Apr 2016 18:08:09 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 72254 invoked by uid 99); 4 Apr 2016 18:08:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Apr 2016 18:08:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 346C8DFC72; Mon, 4 Apr 2016 18:08:09 +0000 (UTC) From: bomeng To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-14123] [SQL] Handle CreateFunction/Drop... Content-Type: text/plain Message-Id: <20160404180809.346C8DFC72@git1-us-west.apache.org> Date: Mon, 4 Apr 2016 18:08:09 +0000 (UTC) Github user bomeng commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58420071 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -534,17 +579,11 @@ class SessionCatalog( val dbFunctions = externalCatalog.listFunctions(db, pattern).map { f => FunctionIdentifier(f, Some(db)) } val regex = pattern.replaceAll("\\*", ".*").r --- End diff -- Please include my fix for that, or create an utility for all the occurrence. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org