Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A260E18F7B for ; Fri, 1 Apr 2016 23:41:41 +0000 (UTC) Received: (qmail 64890 invoked by uid 500); 1 Apr 2016 23:41:41 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 64866 invoked by uid 500); 1 Apr 2016 23:41:41 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 64855 invoked by uid 99); 1 Apr 2016 23:41:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Apr 2016 23:41:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3AA61DFDE3; Fri, 1 Apr 2016 23:41:41 +0000 (UTC) From: zsxwing To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming Content-Type: text/plain Message-Id: <20160401234141.3AA61DFDE3@git1-us-west.apache.org> Date: Fri, 1 Apr 2016 23:41:41 +0000 (UTC) Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12119#discussion_r58281770 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -722,6 +722,16 @@ class SQLConf extends Serializable with CatalystConf with Logging { } /** + * Return the value of Spark SQL configuration property for the given key. If the key is not set + * yet, return `defaultValue` in [[SQLConfEntry]] when available. If there is no default and + * the option is not set, returns `null`. --- End diff -- nit: returns `None`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org