Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: srowen <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12016-spark@git.apache.org>
In-Reply-To: <git-pr-12016-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and
 countAppr...
Content-Type: text/plain
Message-Id: <20160401231334.C8936DFBD6@git1-us-west.apache.org>
Date: Fri,  1 Apr 2016 23:13:34 +0000 (UTC)

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12016#discussion_r58279950
  
    --- Diff: core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
    @@ -0,0 +1,107 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.partial
    +
    +
    +import org.apache.spark._
    +import org.apache.spark.util.StatCounter
    +
    +class SumEvaluatorSuite extends SparkFunSuite with SharedSparkContext {
    +
    +  test("correct handling of count 1") {
    +
    +    //setup
    +    val counter = new StatCounter(List(2.0))
    +    // count of 10 because it's larger than 1,
    +    // and 0.95 because that's the default
    +    val evaluator = new SumEvaluator(10, 0.95)
    +    // arbitrarily assign id 1
    +    evaluator.merge(1, counter)
    +
    +    //execute
    +    val res = evaluator.currentResult()
    +    // 38.0 - 7.1E-15 because that's how the maths shakes out
    +    val targetMean =  38.0 - 7.1E-15
    + 
    +    //Sanity check that equality works on BoundedDouble
    +    assert(new BoundedDouble(2.0, 0.95, 1.1, 1.2) == new BoundedDouble(2.0, 0.95, 1.1, 1.2))
    +
    +    // actual test
    +    assert(res == new BoundedDouble(targetMean, 0.950, Double.NegativeInfinity, Double.PositiveInfinity))
    +  }
    +
    +  test("correct handling of count 0") {
    +
    +    //setup
    +    val counter = new StatCounter(List())
    +    // count of 10 because it's larger than 0,
    +    // and 0.95 because that's the default
    +    val evaluator = new SumEvaluator(10, 0.95)
    +    // arbitrarily assign id 1
    +    evaluator.merge(1, counter)
    +
    +    //execute
    +    val res = evaluator.currentResult()
    +    //assert
    +    assert(res == new BoundedDouble(0, 0.0, Double.NegativeInfinity, Double.PositiveInfinity))
    +  }
    +
    +  test("correct handling of NaN") {
    +
    +    //setup
    +    val counter = new StatCounter(List(1,Double.NaN,2))
    --- End diff --
    
    Close now. It doesn't like the whitespace at ends of lines, and commas everywhere need a spaceafter


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org