spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From taoli91 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14914] Normalize Paths/URIs for windows...
Date Tue, 26 Apr 2016 08:00:50 GMT
GitHub user taoli91 opened a pull request:

    https://github.com/apache/spark/pull/12695

    [SPARK-14914] Normalize Paths/URIs for windows. 

    ## What changes were proposed in this pull request?
    The drive label and the back slash on windows' absolute path would confuse the URI scheme.
This pull request mostly fix the path issue for windows. 
    
    ## How was this patch tested?
    Unit tests
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/taoli91/spark fix_file_path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12695
    
----
commit 2373b56609924b069ec0cfaf10ad887246c0460c
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T03:37:06Z

    mvn.cmd for windows
    
    Helping script for windows to download dependency and start zinc to
    support incremental building on windows.

commit cc7d9a778d82a5156d7716490ebd8dc405f3791e
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T06:46:32Z

    Add helper methods on Utils and Fix fileSuite

commit 9419c36ed3d42ce0e2b3154ebdfe0c68eaef1b06
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T06:56:14Z

    Fix the addFile in SparkContext for win path.
    
    When we pass absolute local path with drive label on windows
    to SparkContext's addFile, the scheme can't be correctly handled
    and it will cause a failure

commit 13559bd80200b81671df77868390f97328050937
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T07:12:34Z

    Fix TestUtils and RPackageUtils, still the back slash problem

commit 071fe90f5b7def2083b99500e4d4d9ed7edfa138
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T07:30:27Z

    Fix file path in JavaAPISuite

commit 54c720fc3404419019d71c386025230309a7361f
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T07:35:22Z

    Fix IvyTstUTils

commit da7d9babc1ba792b192db4eda44b447d5d425e36
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T07:52:17Z

    Fix file uri

commit 66b7b4e38475dc7f6acab6517a8cb4878945b0c3
Author: Tao LI <tl@microsoft.com>
Date:   2016-04-25T07:56:07Z

    Fix file path problem for EventLoggingLIstenerSuite

commit 226c2d489a8b7cb3a18b0533023462a010e68a4a
Author: Tao LI <tl@microsoft.com>
Date:   2016-04-25T08:05:48Z

    Fix the file paths.

commit f07df07dd26b3b7b8cc3bac4221ad28cda852bd7
Author: Tao LI <tl@microsoft.com>
Date:   2016-04-25T08:08:35Z

    Fix the file paths.

commit 54a0f27d557b6f1b4a6157a16bf65de37944d327
Author: Tao LI <tl@microsoft.com>
Date:   2016-04-25T08:23:40Z

    Slash problem

commit 973564ae6c7475e354a1b6d2d7b5a54d716cd2e3
Author: Tao LI <tl@microsoft.com>
Date:   2016-04-25T08:30:52Z

    Another fix.

commit 9dad154905ea6cdc0d77966c4475eee0bd8b1da2
Author: U-FAREAST\tl <tl@microsoft.com>
Date:   2016-04-25T13:47:56Z

    Fixed file path

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message