spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14691] [SQL] Simplify and Unify Error G...
Date Mon, 18 Apr 2016 01:18:42 GMT
GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/12459

    [SPARK-14691] [SQL] Simplify and Unify Error Generation for Unsupported Alter Table DDL

    #### What changes were proposed in this pull request?
    So far, we are capturing each unsupported Alter Table in separate visit functions. They
should be unified and issue the same ParseException instead.
    
    This PR is to refactor the existing implementation and make error message consistent for
Alter Table DDL. 
    
    #### How was this patch tested?
    Updated the existing test cases and also added new test cases to ensure all the unsupported
statements are covered. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark cleanAlterTable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12459
    
----
commit 07a07795baa5ff8ffd4bb72237e872d5b684159e
Author: gatorsmile <gatorsmile@gmail.com>
Date:   2016-04-18T01:12:09Z

    Simplify and unify the exceptions for unsupported alter table DDL statements.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message