spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14518] [SQL] Support Comment in CREATE ...
Date Sun, 10 Apr 2016 15:44:48 GMT
GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/12288

    [SPARK-14518] [SQL] Support Comment in CREATE VIEW

    #### What changes were proposed in this pull request?
    **HQL Syntax**: [Create View](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/AlterView
    )
    ```SQL
    CREATE VIEW [IF NOT EXISTS] [db_name.]view_name [(column_name [COMMENT column_comment],
...) ]
      [COMMENT view_comment]
      [TBLPROPERTIES (property_name = property_value, ...)]
      AS SELECT ...;
    ```
    Add a support for the `[COMMENT view_comment]` clause
    
    #### How was this patch tested?
    Modified the existing test cases to verify the correctness.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark addCommentInCreateView

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12288
    
----
commit 9c6ab488f26de0684d16a52313c07fe60262eade
Author: gatorsmile <gatorsmile@gmail.com>
Date:   2016-04-10T15:40:46Z

    support comment in create view

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message