spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14481] [SQL] [WIP] Issue Exceptions for...
Date Fri, 08 Apr 2016 06:32:53 GMT
GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/12255

    [SPARK-14481] [SQL] [WIP] Issue Exceptions for All Unsupported Options during Parsing

    #### What changes were proposed in this pull request?
    Not good to slightly ignore all the un-supported options/clauses. We should either support
it or throw an exception.
    
    - Can `Explain` be an exception? The `Formatted` clause is used in `HiveCompatibilitySuite`.
    - Two unsupported clauses in `Drop Table` are handled in a separate PR: https://github.com/apache/spark/pull/12146
    
    #### How was this patch tested?
    Todo: added the test cases to ensure they are correctly covered

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark warningToException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12255
    
----
commit 8abcb7129272fda8eceb1295cfb9ca7f0a46eb68
Author: gatorsmile <gatorsmile@gmail.com>
Date:   2016-04-08T06:21:29Z

    warning 2 exceptions

commit b1774f0d3fceab57d9863bcdf35d01881b8dc310
Author: gatorsmile <gatorsmile@gmail.com>
Date:   2016-04-08T06:25:04Z

    Explains are exceptions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message