spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14468] Always enable OutputCommitCoordi...
Date Thu, 07 Apr 2016 22:26:18 GMT
GitHub user andrewor14 opened a pull request:

    https://github.com/apache/spark/pull/12244

    [SPARK-14468] Always enable OutputCommitCoordinator

    ## What changes were proposed in this pull request?
    
    `OutputCommitCoordinator` was introduced to deal with concurrent task attempts racing
to write output, leading to data loss or corruption. For more detail, read the [JIRA description](https://issues.apache.org/jira/browse/SPARK-14468).
    
    Before: `OutputCommitCoordinator` is enabled only if speculation is enabled.
    After: `OutputCommitCoordinator` is always enabled.
    
    Users may still disable this through `spark.hadoop.outputCommitCoordination.enabled`,
but they really shouldn't...
    
    ## How was this patch tested?
    
    `OutputCommitCoordinator*Suite`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrewor14/spark always-occ

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12244
    
----
commit ba7fc4b39645939c44628ff3cdeed8f0dd3965a0
Author: Andrew Or <andrew@databricks.com>
Date:   2016-04-07T22:23:03Z

    Do not tie OutputCommitCoordinator to speculation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message