spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MLnick <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14891][ML] Add schema validation for AL...
Date Fri, 29 Apr 2016 06:40:10 GMT
Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12762#discussion_r61539432
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
    @@ -512,6 +513,60 @@ class ALSSuite
         assert(getFactors(model.userFactors) === getFactors(model2.userFactors))
         assert(getFactors(model.itemFactors) === getFactors(model2.itemFactors))
       }
    +
    +  test("input type validation") {
    +    val sqlContext = this.sqlContext
    +    import sqlContext.implicits._
    +
    +    val test = Seq()
    --- End diff --
    
    ah yes that's a left-over, will remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message