spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12810][PySpark] PySpark CrossValidatorM...
Date Wed, 27 Apr 2016 20:38:35 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12464#discussion_r61331680
  
    --- Diff: python/pyspark/ml/tuning.py ---
    @@ -346,10 +346,11 @@ class CrossValidatorModel(Model, ValidatorParams, MLReadable, MLWritable):
         .. versionadded:: 1.4.0
         """
     
    -    def __init__(self, bestModel):
    +    def __init__(self, bestModel, avgMetrics):
    --- End diff --
    
    I just realized we should add a default value for avgMetrics since it is technically a
public API.  How about a value of ```[]``` by default?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message