spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MLnick <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6717][ML] Clear shuffle files after che...
Date Wed, 27 Apr 2016 19:12:42 GMT
Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11919#discussion_r61318645
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
    @@ -541,4 +585,82 @@ object ALSSuite {
         "nonnegative" -> true,
         "checkpointInterval" -> 20
       )
    +
    +  // Helper functions to generate test data we share between ALS test suites
    +
    +  /**
    +   * Generates random user/item factors, with i.i.d. values drawn from U(a, b).
    +   * @param size number of users/items
    +   * @param rank number of features
    +   * @param random random number generator
    +   * @param a min value of the support (default: -1)
    +   * @param b max value of the support (default: 1)
    +   * @return a sequence of (ID, factors) pairs
    +   */
    +  private def genFactors(
    --- End diff --
    
    yup


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message