spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14754][SPARK CORE] Metrics as logs are ...
Date Tue, 26 Apr 2016 09:06:45 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12697#discussion_r61051439
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/sink/Slf4jSink.scala ---
    @@ -25,6 +25,9 @@ import com.codahale.metrics.{MetricRegistry, Slf4jReporter}
     import org.apache.spark.SecurityManager
     import org.apache.spark.metrics.MetricsSystem
     
    +import org.slf4j.Logger
    +import org.slf4j.LoggerFactory
    --- End diff --
    
    (It would be great if you run `sbt scalastyle` before adding some more commits which shows
up such things)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message