spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14613][ML] Add @Since into the matrix a...
Date Mon, 25 Apr 2016 22:54:56 GMT
Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12416#discussion_r61004014
  
    --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
    @@ -415,13 +443,14 @@ object DenseMatrix {
      *                     Compressed Sparse Row (CSR) format, where `colPtrs` behaves as
rowPtrs,
      *                     and `rowIndices` behave as colIndices, and `values` are stored
in row major.
      */
    -class SparseMatrix (
    -    val numRows: Int,
    -    val numCols: Int,
    -    val colPtrs: Array[Int],
    -    val rowIndices: Array[Int],
    -    val values: Array[Double],
    -    override val isTransposed: Boolean) extends Matrix {
    +@Since("2.0.0")
    +class SparseMatrix @Since("2.0.0") (
    +    @Since("2.0.0") val numRows: Int,
    +    @Since("2.0.0") val numCols: Int,
    +    @Since("2.0.0") val colPtrs: Array[Int],
    +    @Since("2.0.0") val rowIndices: Array[Int],
    +    @Since("2.0.0") val values: Array[Double],
    +    @Since("2.0.0") override val isTransposed: Boolean) extends Matrix {
    --- End diff --
    
    ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message