spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14636] Add minimum memory checks for dr...
Date Sun, 24 Apr 2016 09:45:58 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/12395#issuecomment-213920665
  
    This looks good as a simple guard against typos ("500" instead of "500m") that are otherwise
a little obscure to a new user. It parallels similar checks in the new memory manager. Although
it'd be cleaner if both used `require`, it's not a big deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message