spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <>
Subject [GitHub] spark pull request: [SPARK-14838][SQL] Implement statistics in Ser...
Date Fri, 22 Apr 2016 10:45:22 GMT
Github user viirya commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
    @@ -83,6 +83,28 @@ case class SerializeFromObject(
         child: LogicalPlan) extends UnaryNode with ObjectConsumer {
       override def output: Seq[Attribute] =
    +  // We can't estimate the size of ObjectType. We implement statistics here to avoid
    +  // directly estimate any child plan which produces domain objects as output.
    +  override def statistics: Statistics = {
    +    if (child.output.head.dataType.isInstanceOf[ObjectType]) {
    +      val underlyingPlan = child.find { p =>
    --- End diff --
    Actually, for the case of `MapGroups`, I use the default way to calculate the `sizeInBytes`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message