spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10001] Consolidate Signaling and Signal...
Date Fri, 22 Apr 2016 07:50:42 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12605#discussion_r60702070
  
    --- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
    @@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
     /**
      * Contains utilities for working with posix signals.
      */
    -private[spark] object Signaling extends Logging {
    +private[spark] object SignalUtils extends Logging {
    +
    +  private var registered = false
    +
    +  /** Register a signal handler to log signals on UNIX-like systems. */
    +  def registerLogger(log: Logger): Unit = synchronized {
    --- End diff --
    
    you do know that statement applies to almost all the code in spark right? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message