spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10001] Consolidate Signaling and Signal...
Date Fri, 22 Apr 2016 07:26:22 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12605#discussion_r60700036
  
    --- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
    @@ -51,11 +88,8 @@ private[spark] object Signaling extends Logging {
           // register old handler, will receive incoming signals while this handler is running
           Signal.handle(signal, prevHandler)
     
    -      val escalate = actions.asScala forall { action =>
    -        !action()
    -      }
    -
    -      if(escalate) {
    +      val escalate = actions.asScala.forall { action => !action() }
    --- End diff --
    
    can you write a short description here on what this is doing? it's not very straightforward
(especially the forall and boolean inversion)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message