spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14753][CORE] remove internal flag in Ac...
Date Wed, 20 Apr 2016 18:01:39 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12525#discussion_r60457748
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala ---
    @@ -244,7 +243,12 @@ private[spark] class ListenerTaskMetrics(accumUpdates: Seq[AccumulableInfo])
ext
     
     private[spark] object TaskMetrics extends Logging {
     
    -  def empty: TaskMetrics = new TaskMetrics
    +  def empty: TaskMetrics = {
    --- End diff --
    
    if this is used only in testing, can you make a comment here?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message