spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14675][SQL] ClassFormatError when use S...
Date Tue, 19 Apr 2016 17:50:17 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12468#discussion_r60277819
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -110,13 +110,17 @@ class CodegenContext {
       }
     
       def declareMutableStates(): String = {
    -    mutableStates.map { case (javaType, variableName, _) =>
    +    // It's possible that we add same mutable state twice, e.g. the `mergeExpressions`
in
    +    // `TypedAggregateExpression`, we should call `distinct` here to remove the duplicated
ones.
    --- End diff --
    
    Can we avoid of adding the same mutable state twice?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message