spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14712][ML]spark.ml.LogisticRegressionMo...
Date Tue, 19 Apr 2016 04:46:55 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12491#discussion_r60172784
  
    --- Diff: python/pyspark/mllib/classification.py ---
    @@ -262,6 +262,8 @@ def load(cls, sc, path):
             model.setThreshold(threshold)
             return model
     
    +    def __repr__(self):
    +        return self._call_java("toString")
     
    --- End diff --
    
    I think Python style asks for two new lines here (try running ./dev/lint-python locally
:))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message