spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robbinspg <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13745][SQL]Support columnar in memory r...
Date Mon, 18 Apr 2016 07:47:31 GMT
Github user robbinspg commented on the pull request:

    https://github.com/apache/spark/pull/12397#issuecomment-211247119
  
    I haven't ran any explicit performance tests for this. Do we have any specific to this
area?
    
    Using the static final boolean is allowing the jit to eliminate the dead code path. I
 discussed an alternative implementation with @nongli  in https://github.com/apache/spark/pull/10628#issuecomment-205993243
and the if(...) implementation was deemed ok.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message