spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14628][CORE][folllow-up] Always trackin...
Date Mon, 18 Apr 2016 05:03:06 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12462#discussion_r60006203
  
    --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
    @@ -172,10 +172,10 @@ class TaskMetrics private[spark](
         val resultSerializationTime: Long,
         val memoryBytesSpilled: Long,
         val diskBytesSpilled: Long,
    -    val inputMetrics: Option[InputMetrics],
    -    val outputMetrics: Option[OutputMetrics],
    -    val shuffleReadMetrics: Option[ShuffleReadMetrics],
    -    val shuffleWriteMetrics: Option[ShuffleWriteMetrics])
    +    val inputMetrics: InputMetrics,
    --- End diff --
    
    one thing - can you verify that this doesn't change the json output? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message