spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nongli <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...
Date Fri, 15 Apr 2016 00:50:08 GMT
Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12345#discussion_r59814567
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
    @@ -437,17 +444,21 @@ case class TungstenAggregate(
         val initAgg = ctx.freshName("initAgg")
         ctx.addMutableState("boolean", initAgg, s"$initAgg = false;")
     
    -    // create AggregateHashMap
    -    val isAggregateHashMapEnabled: Boolean = false
    -    val isAggregateHashMapSupported: Boolean =
    +    // We currently only enable vectorized hashmap for long key/value types
    +    isVectorizedHashMapEnabled = isVectorizedHashMapEnabled &&
    --- End diff --
    
    I think it's weird that you have the check split between here and line 268. maybe combine
all these checks to 268 and make isVecdtorizedEnabled a val.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message