spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dilipbiswal <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14445][SQL] Support native execution of...
Date Thu, 14 Apr 2016 20:02:16 GMT
Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12222#discussion_r59781546
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
    @@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
     }
     
     /**
    + * A command for users to list the column names for a table. This function creates a
    + * [[ShowColumnsCommand]] logical plan.
    + *
    + * The syntax of using this command in SQL is:
    + * {{{
    + *   SHOW COLUMNS (FROM | IN) table_identifier [(FROM | IN) database];
    + * }}}
    + */
    +case class ShowColumnsCommand(table: TableIdentifier) extends RunnableCommand {
    +  // The result of SHOW COLUMNS has one column called 'result'
    +  override val output: Seq[Attribute] = {
    +    AttributeReference("result", StringType, nullable = false)() :: Nil
    +  }
    +
    +  override def run(sqlContext: SQLContext): Seq[Row] = {
    +    val relation = sqlContext.sessionState.catalog.lookupRelation(table, None)
    +    relation.schema.fields.map { field =>
    +      Row(field.name)
    +    }
    --- End diff --
    
    @andrewor14 Hi Andrew, actually i remember i had tried this before. The table metadata's
schema does not include partition columns ? Thats why i had used the lookupRelation.. 
    
    Please let me know what you think ..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message