spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nongli <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...
Date Thu, 14 Apr 2016 00:43:18 GMT
Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12345#discussion_r59649964
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ColumnarAggMapCodeGenerator.scala
---
    @@ -21,10 +21,10 @@ import org.apache.spark.sql.catalyst.expressions.codegen.CodegenContext
     import org.apache.spark.sql.types.StructType
     
     /**
    - * This is a helper object to generate an append-only single-key/single value aggregate
hash
    - * map that can act as a 'cache' for extremely fast key-value lookups while evaluating
aggregates
    - * (and fall back to the `BytesToBytesMap` if a given key isn't found). This is 'codegened'
in
    - * TungstenAggregate to speed up aggregates w/ key.
    + * This is a helper class to generate an append-only aggregate hash map that can act
as a 'cache'
    + * for extremely fast key-value lookups while evaluating aggregates (and fall back to
the
    + * `BytesToBytesMap` if a given key isn't found). This is 'codegened' in TungstenAggregate
to speed
    + * up aggregates w/ key.
    --- End diff --
    
    You chose to have this not handle null keys right? Comment that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message