spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14363] Fix executor OOM due to memory l...
Date Tue, 12 Apr 2016 20:25:33 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12285#discussion_r59447040
  
    --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java
---
    @@ -254,7 +252,11 @@ public long spill(long size, MemoryConsumer trigger) throws IOException
{
           spills.size() > 1 ? " times" : " time");
     
         writeSortedFile(false);
    -    final long spillSize = freeMemory();
    +    long spillSize = freeMemory();
    --- End diff --
    
    I'm sorry that I misread this last night, this is spillSize (the number of bytes written
into disk), not the amount of freed memory, so we don't need to add the amount from inMemSorter.
    
    Sorry again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message