spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <>
Subject [GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...
Date Tue, 12 Apr 2016 12:47:02 GMT
Github user cloud-fan commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
    @@ -77,35 +77,19 @@ private[spark] object ClosureCleaner extends Logging {
       private def getInnerClosureClasses(obj: AnyRef): List[Class[_]] = {
         val seen = Set[Class[_]](obj.getClass)
    -    var stack = List[Class[_]](obj.getClass)
    +    val stack = Stack[Class[_]](obj.getClass)
    --- End diff --
    kind of unrelated, but it's obvious that using `Stach` is more efficient here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message