spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Date Tue, 12 Apr 2016 04:12:12 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12081#discussion_r59318540
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
    @@ -121,8 +123,13 @@ class SessionCatalog(
         currentDb = db
       }
     
    -  def getDefaultDBPath(db: String): String = {
    -    System.getProperty("java.io.tmpdir") + File.separator + db + ".db"
    +  def getDatabasePath(dbName: String, path: Option[String]): String = {
    +    val dbPath =
    +      path.map(new Path(_))
    +        .getOrElse(
    +          new Path(new Path(System.getProperty("java.io.tmpdir")), dbName.toLowerCase()
+ ".db"))
    +    val dbLocation = dbPath.toString
    +    if (dbLocation.endsWith(File.separator)) dbLocation.dropRight(1) else dbLocation
    --- End diff --
    
    I guess `File.separator` is platform dependent, right? But, does the separator used by
this platform is the separator used by the underlying FileSystem (the file system implemented
based on Hadoop FS interface)? What is the intention of this line? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message