spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14488][SPARK-14493][SQL] "CREATE TEMPOR...
Date Tue, 12 Apr 2016 00:54:44 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12303#discussion_r59306581
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
    @@ -1852,4 +1852,31 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton
{
           }
         }
       }
    +
    +  test(
    +    "SPARK-14488 \"CREATE TEMPORARY TABLE ... USING ... AS SELECT ...\" " +
    +    "shouldn't create persisted table"
    +  ) {
    +    withTempPath { dir =>
    +      withTempTable("t1", "t2") {
    +        val path = dir.getCanonicalPath
    +        val ds = sqlContext.range(10)
    +        ds.registerTempTable("t1")
    +
    +        sql(
    +          s"""CREATE TEMPORARY TABLE t2
    +             |USING PARQUET
    +             |OPTIONS (PATH '$path')
    +             |AS SELECT * FROM t1
    --- End diff --
    
    By "persisted" I mean the table metadata is persisted into Hive metastore. Since we are
fixing `CreateTempTableUsingAsSelect`, this syntax IS the one we are going to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message