spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14481] [SQL] Issue Exceptions for All U...
Date Sat, 09 Apr 2016 17:08:29 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12255#discussion_r59118041
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
    @@ -162,14 +162,16 @@ class HiveSqlAstBuilder extends SparkSqlAstBuilder {
     
           // Unsupported clauses.
           if (temp) {
    -        logWarning("TEMPORARY clause is ignored.")
    +        throw new ParseException(s"Unsupported operation: TEMPORARY clause.", ctx)
           }
           if (ctx.bucketSpec != null) {
             // TODO add this - we need cluster columns in the CatalogTable for this to work.
    -        logWarning("CLUSTERED BY ... [ORDERED BY ...] INTO ... BUCKETS clause is ignored.")
    +        throw new ParseException("Unsupported operation: " +
    +          "CLUSTERED BY ... [ORDERED BY ...] INTO ... BUCKETS clause.", ctx)
    --- End diff --
    
    I need to double check if insert into hive command can actually understand these fields,
if not, we should not support cluster by and order by for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message