spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14354][SQL] Let Expand take name expres...
Date Sat, 09 Apr 2016 02:56:37 GMT
Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/12138#issuecomment-207689521
  
    If my understanding is right, the problem is: when child output changes(e.g. making them
null when doing a roll up), the output of `Expand` can't reflect it.  I have a simpler idea,
when set the output for `Expand`, use a placeholder to reference to a child column, and define
a `output` method in `Expand` that replace the placeholder with child attribute. How about
it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message