spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...
Date Wed, 06 Apr 2016 02:21:53 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12181#discussion_r58643476
  
    --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/sources/JavaDatasetAggregatorSuite.java
---
    @@ -170,3 +130,47 @@ public Long call(Tuple2<String, Integer> value) throws Exception
{
         Assert.assertEquals(Arrays.asList(tuple2("a", 3), tuple2("b", 3)), agged.collectAsList());
       }
     }
    +
    +/**
    + * Common test base shared across this and Java8DatasetAggregatorSuite.
    + */
    +class JavaDatasetAggregatorSuiteBase implements Serializable {
    --- End diff --
    
    weird you got two here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message