spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13430][PySpark][ML] Python API for trai...
Date Tue, 05 Apr 2016 23:12:35 GMT
Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11621#discussion_r58629672
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
    @@ -777,10 +777,10 @@ sealed trait LogisticRegressionSummary extends Serializable {
       /** Dataframe outputted by the model's `transform` method. */
       def predictions: DataFrame
     
    -  /** Field in "predictions" which gives the calibrated probability of each instance
as a vector. */
    +  /** Field in "predictions" which gives the calibrated probability of each class as
a vector. */
       def probabilityCol: String
     
    -  /** Field in "predictions" which gives the true label of each instance. */
    +  /** Field in "predictions" which gives the true label of each instance (if available).
*/
    --- End diff --
    
    I removed the "(if available)" from all other descriptions but this generic trait because
even in the `LinearRegressionSummary` class, for instance, it assumes that a `labelCol` always
exists so it can calculate the summary metrics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message