spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14370][MLLIB]removed duplicate generati...
Date Tue, 05 Apr 2016 16:24:22 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/12176#issuecomment-205882669
  
    A-ha, understood about `.values`. This looks pretty reasonable. My only question is, does
it make sense conceptually that this method also returns a list of IDs? it doesn't hurt much
in practice, and it seems like there's a reasonable argument for it logically. We have one
case where the caller needs it after all. Maybe finish this by documenting the three things
returned from this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message