spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brkyvz <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...
Date Tue, 05 Apr 2016 04:59:40 GMT
Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12141#discussion_r58487027
  
    --- Diff: R/pkg/inst/tests/testthat/test_context.R ---
    @@ -36,7 +36,7 @@ test_that("Check masked functions", {
                                             any(grepl("=\"ANY\"", capture.output(showMethods(x)[-1])))
                                           }))
       maskedCompletely <- masked[!funcHasAny]
    -  namesOfMaskedCompletely <- c("cov", "filter", "sample")
    +  namesOfMaskedCompletely <- c("cov", "filter", "sample", "window")
    --- End diff --
    
    I see... Thanks for pointing it out! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message