spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yongtang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...
Date Tue, 05 Apr 2016 02:09:49 GMT
Github user yongtang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11989#discussion_r58478120
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
    @@ -360,7 +362,8 @@ private[ml] trait RandomForestParams extends TreeEnsembleParams {
         "The number of features to consider for splits at each tree node." +
           s" Supported options: ${RandomForestParams.supportedFeatureSubsetStrategies.mkString(",
")}",
         (value: String) =>
    -      RandomForestParams.supportedFeatureSubsetStrategies.contains(value.toLowerCase))
    +      RandomForestParams.supportedFeatureSubsetStrategies.contains(value.toLowerCase)
    +      || value.matches("^(?:[1-9]\\d*|0\\.\\d*[1-9]\\d*\\d*|1\\.0+)$"))
    --- End diff --
    
    Thanks @MLnick @sethah. In `0\\.\\d*[1-9]\\d*\\d*` the last `\\d*` is to capture situations
of trailing zero `"0.0250"`. I didn't take into consideration of `".25"` case initially.
    
    Let me update the pull request and address those issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message