spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14123] [SQL] Handle CreateFunction/Drop...
Date Mon, 04 Apr 2016 21:43:27 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12117#discussion_r58454405
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
    @@ -146,6 +146,7 @@ abstract class ExternalCatalog {
     
       def createFunction(db: String, funcDefinition: CatalogFunction): Unit
     
    +  // TODO: dropFunction should take a FunctionIdentifier.
    --- End diff --
    
    I don't think so... it's largely by design that we just pass in the strings here. This
is the external catalog which shouldn't know anything about current databases, so the effective
database should already be resolved at this point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message