spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bomeng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14123] [SQL] Handle CreateFunction/Drop...
Date Mon, 04 Apr 2016 18:08:09 GMT
Github user bomeng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12117#discussion_r58420071
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
    @@ -534,17 +579,11 @@ class SessionCatalog(
         val dbFunctions =
           externalCatalog.listFunctions(db, pattern).map { f => FunctionIdentifier(f,
Some(db)) }
         val regex = pattern.replaceAll("\\*", ".*").r
    --- End diff --
    
    Please include my fix for that, or create an utility for all the occurrence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message