spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Date Mon, 04 Apr 2016 17:21:17 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12087#discussion_r58412559
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
    @@ -68,6 +71,69 @@ case class MapPartitions(
     }
     
     /**
    + * Applies the given function to each input row and encodes the result.
    + *
    + * TODO: Each serializer expression needs the result object which is returned by the
given function,
    --- End diff --
    
    I would soften this.  Its not clear that removing this small amount of code duplication
is worth the confusion that would result in showing the un-common-subexpression-eliminated
version of a project in the explain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message