spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...
Date Fri, 01 Apr 2016 06:26:55 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12099#discussion_r58166528
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
    @@ -101,4 +101,19 @@ class HiveExplainSuite extends QueryTest with SQLTestUtils with TestHiveSingleto
             "Physical Plan should not contain Subquery since it's eliminated by optimizer")
         }
       }
    +
    +  test("SPARK-14251: EXPLAIN CODEGEN command") {
    --- End diff --
    
    Ok.
    
    Regarding the name of the test. I would typically only add the JIRA number to test name
if it fixes a bug (that needs some explanation).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message