Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 942D219E69 for ; Sat, 26 Mar 2016 23:57:20 +0000 (UTC) Received: (qmail 70926 invoked by uid 500); 26 Mar 2016 23:57:20 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 70900 invoked by uid 500); 26 Mar 2016 23:57:20 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 70889 invoked by uid 99); 26 Mar 2016 23:57:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Mar 2016 23:57:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5E885DFDE0; Sat, 26 Mar 2016 23:57:19 +0000 (UTC) From: yongtang To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr... Content-Type: text/plain Message-Id: <20160326235719.5E885DFDE0@git1-us-west.apache.org> Date: Sat, 26 Mar 2016 23:57:19 +0000 (UTC) Github user yongtang commented on a diff in the pull request: https://github.com/apache/spark/pull/11981#discussion_r57521128 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -42,6 +42,14 @@ private[spark] class SumEvaluator(totalOutputs: Int, confidence: Double) new BoundedDouble(counter.sum, 1.0, counter.sum, counter.sum) } else if (outputsMerged == 0) { new BoundedDouble(0, 0.0, Double.NegativeInfinity, Double.PositiveInfinity) + } else if (counter.count == 0) { + new BoundedDouble(0, 0.0, Double.NegativeInfinity, Double.PositiveInfinity) --- End diff -- Thanks. Just updated the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org