Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5B5218AAB for ; Wed, 23 Mar 2016 22:05:34 +0000 (UTC) Received: (qmail 22999 invoked by uid 500); 23 Mar 2016 22:05:34 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 22979 invoked by uid 500); 23 Mar 2016 22:05:34 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 22968 invoked by uid 99); 23 Mar 2016 22:05:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Mar 2016 22:05:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5958FDFAFF; Wed, 23 Mar 2016 22:05:34 +0000 (UTC) From: tejasapatil To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ... Content-Type: text/plain Message-Id: <20160323220534.5958FDFAFF@git1-us-west.apache.org> Date: Wed, 23 Mar 2016 22:05:34 +0000 (UTC) Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-200562818 @liancheng + @marmbrus : Thanks for your comments. I have made the suggested changes except the one related to test case which I am not sure how to do. Also, the PR failed to build on Jenkins but it builds fine on my end when I do: build/sbt scalastyle catalyst/compile sql/compile hive/compile build/sbt -Pyarn -Phadoop-2.3 -Phive package assembly/assembly I looked at the jenkins log and I *guess* that incremental compilation makes it not see the new class `OrcConversions` added in `HiveSessionCatalog`. Is there a way to avoid that ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org