Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: liancheng <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-11775-spark@git.apache.org>
In-Reply-To: <git-pr-11775-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-13774][SQL] - Improve error
 message for...
Content-Type: text/plain
Message-Id: <20160322123550.0FA30DFB7B@git1-us-west.apache.org>
Date: Tue, 22 Mar 2016 12:35:50 +0000 (UTC)

Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11775#discussion_r56978205
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
    @@ -205,7 +205,16 @@ case class DataSource(
               val hdfsPath = new Path(path)
               val fs = hdfsPath.getFileSystem(sqlContext.sparkContext.hadoopConfiguration)
               val qualified = hdfsPath.makeQualified(fs.getUri, fs.getWorkingDirectory)
    -          SparkHadoopUtil.get.globPathIfNecessary(qualified)
    +          val globPath = SparkHadoopUtil.get.globPathIfNecessary(qualified)
    +
    +          if (globPath.isEmpty) {
    +            throw new AnalysisException(s"Path does not exist: $qualified")
    +          }
    +          // Sufficient to check head of the globPath seq for non-glob scenario
    +          if (!fs.exists(globPath.head)) {
    +            throw new AnalysisException(s"Path does not exist: ${globPath.head}")
    +          }
    --- End diff --
    
    Does this mean if the first glob-ed path does exist but all the rest doesn't, then we won't throw this exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org