Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: davies <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-11509-spark@git.apache.org>
In-Reply-To: <git-pr-11509-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns
 of Ha...
Content-Type: text/plain
Message-Id: <20160304204855.8578FE788C@git1-us-west.apache.org>
Date: Fri,  4 Mar 2016 20:48:55 +0000 (UTC)

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11509#discussion_r55086715
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelation.scala ---
    @@ -58,18 +57,29 @@ import org.apache.spark.util.Utils
      *      thrown during job commitment, also aborts the job.
      */
     private[sql] case class InsertIntoHadoopFsRelation(
    -    @transient relation: HadoopFsRelation,
    +    outputPath: Path,
    +    partitionColumns: Seq[Attribute],
    +    bucketSpec: Option[BucketSpec],
    +    fileFormat: FileFormat,
    --- End diff --
    
    Thanks, forgot to search using `trait`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org