Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: marmbrus <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-11509-spark@git.apache.org>
In-Reply-To: <git-pr-11509-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns
 of Ha...
Content-Type: text/plain
Message-Id: <20160304192747.81C17E56E2@git1-us-west.apache.org>
Date: Fri,  4 Mar 2016 19:27:47 +0000 (UTC)

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11509#discussion_r55076507
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
    @@ -103,7 +103,7 @@ object DataType {
     
       /** Given the string representation of a type, return its DataType */
       private def nameToType(name: String): DataType = {
    -    val FIXED_DECIMAL = """decimal\(\s*(\d+)\s*,\s*(\d+)\s*\)""".r
    +    val FIXED_DECIMAL = """decimal\(\s*(\d+)\s*,\s*(\-?\d+)\s*\)""".r
    --- End diff --
    
    [This test case](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala#L782) is hard coded to have a negative value here.  I'm not actually sure if thats correct, but I would argue either way that we should be more permissive about parsing (otherwise the error message is `Unknown DataType`) and then throw a more sensible validation failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org