spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14244][SQL][WIP] Don't use SizeBasedWin...
Date Tue, 29 Mar 2016 16:55:02 GMT
GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/12040

    [SPARK-14244][SQL][WIP] Don't use SizeBasedWindowFunction.n created on executor side when
evaluating window functions

    ## What changes were proposed in this pull request?
    
    `SizeBasedWindowFunction.n` is a global singleton attribute created for evaluating size
based aggregate window functions like `CUME_DIST`. However, this attribute gets different
expression IDs when created on both driver side and executor side. This PR stops using `SizeBasedWindowFunction.n`
created on executor side.
    
    ## How was this patch tested?
    
    TBD. Testing this bugfix requires starting a multi-process cluster. Trying to figure out
a proper way to test it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark spark-14244-fix-sized-window-function

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12040
    
----
commit 65bc6ae8f614d67ec53e170d0f1ebf8b1a56516a
Author: Cheng Lian <lian@databricks.com>
Date:   2016-03-29T16:49:44Z

    Reuses driver side created SizeBasedWindowFunction.n

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message