spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14164] Improve input layer validation t...
Date Fri, 25 Mar 2016 20:14:08 GMT
GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/11964

    [SPARK-14164] Improve input layer validation to MultilayerPerceptronClassifier

    ## What changes were proposed in this pull request?
    
    This issue improves an input layer validation and related testcases to MultilayerPerceptronClassifier.
    
    ```scala
    -    // TODO: how to check ALSO that all elements are greater than 0?
    -    ParamValidators.arrayLengthGt(1)
    +    (t: Array[Int]) => t.forall(ParamValidators.gt(0)) && t.length > 1
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins tests including the new testcases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-14164

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11964
    
----
commit 8cd2d8524ed84c5fc407a56f129ee3440bce530b
Author: Dongjoon Hyun <dongjoon@apache.org>
Date:   2016-03-25T20:10:29Z

    [SPARK-14164] Improve input layer validation to MultilayerPerceptronClassifier

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message