spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <>
Subject [GitHub] spark pull request: [SPARK-13617][SQL] remove unnecessary Grouping...
Date Wed, 02 Mar 2016 13:27:11 GMT
GitHub user cloud-fan opened a pull request:

    [SPARK-13617][SQL] remove unnecessary GroupingAnalytics trait

    ## What changes were proposed in this pull request?
    The `trait GroupingAnalytics` only has one implementation, it's an unnecessary abstraction.
This PR removes it, and does some code simplification when resolving `GroupingSet`.
    ## How was this patch tested?
    existing tests

You can merge this pull request into a Git repository by running:

    $ git pull groupingset

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11469
commit d7424eb2bf91bf7ca087c1c232850f7d8feaa69f
Author: Wenchen Fan <>
Date:   2016-03-02T13:23:15Z

    clean up


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message