spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching
Date Thu, 31 Mar 2016 21:39:27 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11805#discussion_r58132356
  
    --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java ---
    @@ -144,6 +147,34 @@ public static long reallocateMemory(long address, long oldSize, long
newSize) {
         return newMemory;
       }
     
    +  /**
    +   * Uses internal JDK APIs to allocate a DirectByteBuffer while ignoring the JVM's
    +   * MaxDirectMemorySize limit.
    --- End diff --
    
    can you expand on this briefly to explain why we do this ourselves instead of calling
`DirectByteBuffer` directly? It's cause the limit is too low (512m) by default right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message